From reviews-return-22201-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 29 19:02:10 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2A46D17F63 for ; Fri, 29 Jan 2016 19:02:10 +0000 (UTC) Received: (qmail 85617 invoked by uid 500); 29 Jan 2016 19:02:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 85591 invoked by uid 500); 29 Jan 2016 19:02:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 85577 invoked by uid 99); 29 Jan 2016 19:02:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 19:02:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0B0BA289ABA; Fri, 29 Jan 2016 19:02:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4660704309848630306==" MIME-Version: 1.0 Subject: Re: Review Request 42936: Edited flag help strings for style. From: Vinod Kone To: Vinod Kone Cc: Greg Mann , mesos Date: Fri, 29 Jan 2016 19:02:09 -0000 Message-ID: <20160129190209.12172.14541@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42936/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20160129053413.12172.21809@reviews.apache.org> In-Reply-To: <20160129053413.12172.21809@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============4660704309848630306== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/#review116982 ----------------------------------------------------------- Fix it, then Ship it! src/master/main.cpp (line 126) s/this/This/ src/master/main.cpp (line 132) No need to explicitly specify the default? src/slave/flags.cpp (line 66) backticks around `filepath` like you did below for `--modules`. src/slave/flags.cpp (line 156) no back ticks around `rack:2`? src/slave/flags.cpp (line 542) why is this a backtick? src/slave/main.cpp (line 99) s/this/This/ src/slave/main.cpp (line 105) no need for "(default: 5050). - Vinod Kone On Jan. 29, 2016, 5:34 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42936/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 5:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4298 > https://issues.apache.org/jira/browse/MESOS-4298 > > > Repository: mesos > > > Description > ------- > > Edited flag help strings for style. > > Backticks were inserted where appropriate. This not only matches the convention in the comments within our code, helps to enable the automatic generation of markdown-formatted documentation from these help strings. > > > Diffs > ----- > > src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d > src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd > src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae > src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b > src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 > > Diff: https://reviews.apache.org/r/42936/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > > --===============4660704309848630306==--