From reviews-return-22096-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 28 22:10:59 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A350318913 for ; Thu, 28 Jan 2016 22:10:59 +0000 (UTC) Received: (qmail 74262 invoked by uid 500); 28 Jan 2016 22:10:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74240 invoked by uid 500); 28 Jan 2016 22:10:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74226 invoked by uid 99); 28 Jan 2016 22:10:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 22:10:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A0BD32897F2; Thu, 28 Jan 2016 22:10:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0829735619158384749==" MIME-Version: 1.0 Subject: Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest. From: Anand Mazumdar To: Jie Yu Cc: Jojy Varghese , Anand Mazumdar , mesos Date: Thu, 28 Jan 2016 22:10:55 -0000 Message-ID: <20160128221055.25059.97132@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anand Mazumdar X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42554/ X-Sender: Anand Mazumdar References: <20160128220817.12172.64606@reviews.apache.org> In-Reply-To: <20160128220817.12172.64606@reviews.apache.org> Reply-To: Anand Mazumdar X-ReviewRequest-Repository: mesos --===============0829735619158384749== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 28, 2016, 10:08 p.m., Anand Mazumdar wrote: > > include/mesos/mesos.proto, line 1637 > > > > > > hmmm .. we have generally just used `name` as the field-name at other places for specifying the image name in this file. What is different about this occurence? > > > > In a similar vein, `imageID` should just be `id`? > > Jie Yu wrote: > Anand, the reason is that we need to match the same in the following spec: > https://github.com/appc/spec/blob/master/spec/aci.md > > So that our json->protobuf parsing will work properly. Gotcha, thanks! - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116823 ----------------------------------------------------------- On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42554/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 2:19 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added 'dependencies' message to AppcImageManifest. > > > Diffs > ----- > > include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b > > Diff: https://reviews.apache.org/r/42554/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > > --===============0829735619158384749==--