From reviews-return-22022-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 28 02:24:28 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB60D18F8F for ; Thu, 28 Jan 2016 02:24:28 +0000 (UTC) Received: (qmail 77718 invoked by uid 500); 28 Jan 2016 02:24:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 77689 invoked by uid 500); 28 Jan 2016 02:24:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77672 invoked by uid 99); 28 Jan 2016 02:24:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 02:24:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9C8632894FB; Thu, 28 Jan 2016 02:24:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0758513997696652108==" MIME-Version: 1.0 Subject: Re: Review Request 42888: Used absolute paths for excludes paths in posix disk isolator. From: Joris Van Remoortere To: Joris Van Remoortere , Artem Harutyunyan Cc: Jie Yu , mesos Date: Thu, 28 Jan 2016 02:24:24 -0000 Message-ID: <20160128022424.12173.52455@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42888/ X-Sender: Joris Van Remoortere X-ReviewBoard-ShipIt: 1 References: <20160128011435.12173.7851@reviews.apache.org> In-Reply-To: <20160128011435.12173.7851@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============0758513997696652108== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42888/#review116700 ----------------------------------------------------------- Ship it! Ship It! - Joris Van Remoortere On Jan. 28, 2016, 1:14 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42888/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 1:14 a.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-4539 > https://issues.apache.org/jira/browse/MESOS-4539 > > > Repository: mesos > > > Description > ------- > > Used absolute paths for excludes paths in posix disk isolator. > > We should consistently use absolute paths for excludes paths in disk isolator, otherwise, it's possible that some other paths under the directory matches the relative path, causing incorrect disk usage being reported. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/posix/disk.hpp 5607c0f43084f491e4927f5c6ec283210aa5f355 > src/slave/containerizer/mesos/isolators/posix/disk.cpp d5bf8c10b9cfb360a7856144d59ce89060de5c99 > > Diff: https://reviews.apache.org/r/42888/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > > --===============0758513997696652108==--