From reviews-return-22015-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 28 02:13:32 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00E2018F5D for ; Thu, 28 Jan 2016 02:13:32 +0000 (UTC) Received: (qmail 54080 invoked by uid 500); 28 Jan 2016 02:13:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 54050 invoked by uid 500); 28 Jan 2016 02:13:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 54033 invoked by uid 99); 28 Jan 2016 02:13:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 02:13:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 24FBB2894F6; Thu, 28 Jan 2016 02:13:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5445049914111795558==" MIME-Version: 1.0 Subject: Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota. From: Qian Zhang To: Joris Van Remoortere Cc: mesos , Michael Park , Qian Zhang Date: Thu, 28 Jan 2016 02:13:31 -0000 Message-ID: <20160128021331.25059.13661@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42835/ X-Sender: Qian Zhang References: <20160127013139.12172.95406@reviews.apache.org> In-Reply-To: <20160127013139.12172.95406@reviews.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============5445049914111795558== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42835/#review116695 ----------------------------------------------------------- src/master/allocator/mesos/hierarchical.cpp (line 1341) Should `any more non-revocable` be `any more non-reserved`? - Qian Zhang On Jan. 27, 2016, 9:31 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42835/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 9:31 a.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Eventually, we will also want to offer unreserved resources as revocable beyond > the role's quota. In the short term, we do not offer unreserved, non-revocable > resources beyond a role's quota. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae > src/tests/hierarchical_allocator_tests.cpp 7d5eed4dd4ad2d23e925d5cac73675752b016086 > > Diff: https://reviews.apache.org/r/42835/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > > --===============5445049914111795558==--