From reviews-return-21984-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 27 23:57:16 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EABA518AC4 for ; Wed, 27 Jan 2016 23:57:15 +0000 (UTC) Received: (qmail 11045 invoked by uid 500); 27 Jan 2016 23:57:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 11016 invoked by uid 500); 27 Jan 2016 23:57:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 10999 invoked by uid 99); 27 Jan 2016 23:57:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 23:57:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 18E791D9D57; Wed, 27 Jan 2016 23:57:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4700716121688134947==" MIME-Version: 1.0 Subject: Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`. From: Joris Van Remoortere To: Jie Yu , Joris Van Remoortere Cc: Michael Park , mesos Date: Wed, 27 Jan 2016 23:57:15 -0000 Message-ID: <20160127235715.12172.1645@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42876/ X-Sender: Joris Van Remoortere X-ReviewBoard-ShipIt: 1 References: <20160127225011.12173.1776@reviews.apache.org> In-Reply-To: <20160127225011.12173.1776@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============4700716121688134947== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/#review116656 ----------------------------------------------------------- Ship it! Ship It! - Joris Van Remoortere On Jan. 27, 2016, 10:50 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42876/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 10:50 p.m.) > > > Review request for mesos, Jie Yu and Joris Van Remoortere. > > > Bugs: MESOS-4534 > https://issues.apache.org/jira/browse/MESOS-4534 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa > include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c > src/master/allocator/mesos/hierarchical.cpp dbc77a2d0ce797eea2287b0242f5d2da81c16455 > src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 > src/slave/resource_estimators/fixed.cpp aedd08df8db59be49b374e61eb268a947d35acea > src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 > > Diff: https://reviews.apache.org/r/42876/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > > --===============4700716121688134947==--