From reviews-return-21973-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 27 22:52:48 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 71165187CE for ; Wed, 27 Jan 2016 22:52:48 +0000 (UTC) Received: (qmail 47806 invoked by uid 500); 27 Jan 2016 22:52:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47780 invoked by uid 500); 27 Jan 2016 22:52:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47765 invoked by uid 99); 27 Jan 2016 22:52:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 22:52:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B9211D9D57; Wed, 27 Jan 2016 22:52:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4050732518707804165==" MIME-Version: 1.0 Subject: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests. From: Neil Conway To: Joris Van Remoortere , Greg Mann Cc: Neil Conway , mesos Date: Wed, 27 Jan 2016 22:52:47 -0000 Message-ID: <20160127225247.12172.88056@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42877/ X-Sender: Neil Conway Reply-To: Neil Conway X-ReviewRequest-Repository: mesos --===============4050732518707804165== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/ ----------------------------------------------------------- Review request for mesos, Greg Mann and Joris Van Remoortere. Repository: mesos Description ------- For consistency, we should do `driver.stop(); driver.join();` if a `MesosSchedulerDriver` has been started by the unit test. The destructor for `MesosSchedulerDriver` will do something _similar_, so the consequence of omitting these calls is not dire, but it seems safer to be consistent between all the test cases. Diffs ----- src/tests/executor_http_api_tests.cpp 36a042ed103271ca873450236f39a8152fbbf07e src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf src/tests/reservation_endpoints_tests.cpp 35c093567b07a11ca6eee85e2ff91894a460a7af src/tests/scheduler_event_call_tests.cpp bd8920fa9d5475e5f6533c8424ebff1588bfe645 src/tests/scheduler_http_api_tests.cpp 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead Diff: https://reviews.apache.org/r/42877/diff/ Testing ------- make check Thanks, Neil Conway --===============4050732518707804165==--