From reviews-return-21961-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 27 21:22:58 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D9ACB182E0 for ; Wed, 27 Jan 2016 21:22:58 +0000 (UTC) Received: (qmail 61064 invoked by uid 500); 27 Jan 2016 21:22:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 61033 invoked by uid 500); 27 Jan 2016 21:22:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61017 invoked by uid 99); 27 Jan 2016 21:22:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 21:22:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AE1391D9D57; Wed, 27 Jan 2016 21:22:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7081668451764986838==" MIME-Version: 1.0 Subject: Re: Review Request 42603: Added an http::Authenticator factory. From: Alexander Rojas To: Benjamin Bannier , Jan Schlicht , Alexander Rukletsov , Till Toenshoff Cc: mesos , Alexander Rojas Date: Wed, 27 Jan 2016 21:22:51 -0000 Message-ID: <20160127212251.12173.86593@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42603/ X-Sender: Alexander Rojas References: <20160127153827.12172.40177@reviews.apache.org> In-Reply-To: <20160127153827.12172.40177@reviews.apache.org> X-ReviewBoard-Diff-For: src/authentication/http/authenticator.cpp X-ReviewBoard-Diff-For: src/authentication/http/basic_authenticator_factory.cpp X-ReviewBoard-Diff-For: include/mesos/authentication/http/basic_authenticator_factory.hpp X-ReviewBoard-Diff-For: include/mesos/authentication/http/authenticator.hpp Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos --===============7081668451764986838== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ ----------------------------------------------------------- (Updated Jan. 27, 2016, 10:22 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan Schlicht, and Till Toenshoff. Changes ------- Rebase. Repository: mesos Description ------- Move the code required to instanciate instances of `process::http::authentication::Authenticator` in `src/master/main.cpp` to its own factory. Diffs (updated) ----- include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 src/Makefile.am bdb34020043f64c07721b3e8b29b2cccc21e5b99 src/authentication/http/authenticator.cpp PRE-CREATION src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682 src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906 src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352 Diff: https://reviews.apache.org/r/42603/diff/ Testing ------- make check Thanks, Alexander Rojas --===============7081668451764986838==--