From reviews-return-21917-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 27 08:59:36 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90D7A18A37 for ; Wed, 27 Jan 2016 08:59:36 +0000 (UTC) Received: (qmail 46316 invoked by uid 500); 27 Jan 2016 08:59:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 46289 invoked by uid 500); 27 Jan 2016 08:59:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46275 invoked by uid 99); 27 Jan 2016 08:59:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 08:59:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A0EDE1D9D57; Wed, 27 Jan 2016 08:59:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6897437573473671263==" MIME-Version: 1.0 Subject: Re: Review Request 42685: Added roles validation to master. From: Mesos ReviewBot To: Benjamin Bannier , Vinod Kone Cc: Mesos ReviewBot , mesos , Qian Zhang Date: Wed, 27 Jan 2016 08:59:35 -0000 Message-ID: <20160127085935.12173.27189@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42685/ X-Sender: Mesos ReviewBot References: <20160127052655.12173.66389@reviews.apache.org> In-Reply-To: <20160127052655.12173.66389@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============6897437573473671263== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review116564 ----------------------------------------------------------- Patch looks great! Reviews applied: [42415, 42685] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 27, 2016, 5:26 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42685/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 5:26 a.m.) > > > Review request for mesos, Benjamin Bannier and Vinod Kone. > > > Bugs: MESOS-4364 > https://issues.apache.org/jira/browse/MESOS-4364 > > > Repository: mesos > > > Description > ------- > > Validated either role or roles in FrameworkInfo can be set, > but never both. > > > Diffs > ----- > > src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > > Diff: https://reviews.apache.org/r/42685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > > --===============6897437573473671263==--