From reviews-return-21864-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 27 00:00:44 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 069B018866 for ; Wed, 27 Jan 2016 00:00:44 +0000 (UTC) Received: (qmail 57378 invoked by uid 500); 27 Jan 2016 00:00:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57350 invoked by uid 500); 27 Jan 2016 00:00:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57335 invoked by uid 99); 27 Jan 2016 00:00:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 00:00:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 02249288F14; Wed, 27 Jan 2016 00:00:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5709342454203153475==" MIME-Version: 1.0 Subject: Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6. From: Benjamin Hindman To: Artem Harutyunyan , Till Toenshoff , Benjamin Hindman Cc: Joseph Wu , mesos Date: Wed, 27 Jan 2016 00:00:43 -0000 Message-ID: <20160127000043.12173.19616@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Hindman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42820/ X-Sender: Benjamin Hindman X-ReviewBoard-ShipIt: 1 References: <20160126234528.12172.40412@reviews.apache.org> In-Reply-To: <20160126234528.12172.40412@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Benjamin Hindman X-ReviewRequest-Repository: mesos --===============5709342454203153475== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42820/#review116484 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Hindman On Jan. 26, 2016, 11:45 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42820/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff. > > > Bugs: MESOS-4515 > https://issues.apache.org/jira/browse/MESOS-4515 > > > Repository: mesos > > > Description > ------- > > The `logrotate --version` flag is actually a very recent addition (3.9.1). > The `--help` flag is more likely to be present on a supported system-with-logrotate, given logrotate's usage of popopt. > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 > src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f > > Diff: https://reviews.apache.org/r/42820/diff/ > > > Testing > ------- > > make check (OSX & Centos6.7 & Centos7) > > > Thanks, > > Joseph Wu > > --===============5709342454203153475==--