From reviews-return-21788-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 26 16:26:13 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DAF417F12 for ; Tue, 26 Jan 2016 16:26:13 +0000 (UTC) Received: (qmail 82298 invoked by uid 500); 26 Jan 2016 16:24:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 82057 invoked by uid 500); 26 Jan 2016 16:24:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 79390 invoked by uid 99); 26 Jan 2016 16:23:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 16:23:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EDF5B288CCC; Tue, 26 Jan 2016 16:23:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6223374997323064366==" MIME-Version: 1.0 Subject: Re: Review Request 42477: Corrected example in quota user doc. From: Alexander Rukletsov To: Joerg Schad , Joris Van Remoortere , Bernd Mathiske Cc: Alexander Rukletsov , Guangya Liu , mesos Date: Tue, 26 Jan 2016 16:23:19 -0000 Message-ID: <20160126162319.12173.80329@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42477/ X-Sender: Alexander Rukletsov References: <20160122163430.7986.478@reviews.apache.org> In-Reply-To: <20160122163430.7986.478@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============6223374997323064366== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote: > > docs/quota.md, line 166 > > > > > > Please explain what this seemingly redundant field is doing. > > Guangya Liu wrote: > I think this is because the current Quota can only works for unreserved and non revocable resources. There is indeed a document https://github.com/apache/mesos/blob/master/docs/quota.md for this, make sense? > > Joerg Schad wrote: > We use the default Resource protobuf message which includes an optional default field > ```optional string role = 6 [default = "*"];``` (https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L563). Note this is the status endpoint, i.e. this field is not used to specify quota. > > Alexander Rukletsov wrote: > I agree with Bernd that printing out this field is misleading. Why we do so in the first place? Because that's how JSON is rendered from protobuf by default. Is this is a good reason not to care about it? Probably not. Moreover, we have a family of `model()` functions that specify how certain protobufs should be rendered in JSON (including `Resource`). > > I think we can fix the current issue (this patch documents what is actually being returned) and file a separate ticket for more consistent rendering of `QuotaStatus`. Does it sound right, fellas? > > Bernd Mathiske wrote: > I agree with Alex. Filed https://issues.apache.org/jira/browse/MESOS-4512. Dropping the issue. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42477/#review115854 ----------------------------------------------------------- On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42477/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 3:43 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d > > Diff: https://reviews.apache.org/r/42477/diff/ > > > Testing > ------- > > None: Not a functional change. > > > Thanks, > > Alexander Rukletsov > > --===============6223374997323064366==--