From reviews-return-21554-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Jan 23 17:24:03 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C2A518F3A for ; Sat, 23 Jan 2016 17:24:03 +0000 (UTC) Received: (qmail 22787 invoked by uid 500); 23 Jan 2016 17:24:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22753 invoked by uid 500); 23 Jan 2016 17:24:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22736 invoked by uid 99); 23 Jan 2016 17:24:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jan 2016 17:24:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F8C51CC3E3; Sat, 23 Jan 2016 17:24:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3575354158505068012==" MIME-Version: 1.0 Subject: Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'. From: Jie Yu To: Jie Yu , Michael Park Cc: Joris Van Remoortere , mesos Date: Sat, 23 Jan 2016 17:24:02 -0000 Message-ID: <20160123172402.32314.21385@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42683/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20160123105224.32315.58191@reviews.apache.org> In-Reply-To: <20160123105224.32315.58191@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============3575354158505068012== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42683/#review115990 ----------------------------------------------------------- Fix it, then Ship it! src/tests/resources_tests.cpp (lines 1715 - 1741) I don't think those are necessary. Can you just test resource equality and 'contains' for disk resources like you did below. PS: you already have TEST(DiskResourcesTest, DiskSourceEquals) src/tests/resources_tests.cpp (line 1830) Kill this line - Jie Yu On Jan. 23, 2016, 10:52 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42683/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 10:52 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 > > Diff: https://reviews.apache.org/r/42683/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > > --===============3575354158505068012==--