From reviews-return-21499-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Jan 23 01:26:34 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8609B18B83 for ; Sat, 23 Jan 2016 01:26:34 +0000 (UTC) Received: (qmail 59841 invoked by uid 500); 23 Jan 2016 01:26:34 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 59813 invoked by uid 500); 23 Jan 2016 01:26:34 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 59793 invoked by uid 99); 23 Jan 2016 01:26:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jan 2016 01:26:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0F02C282FB6; Sat, 23 Jan 2016 01:26:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8697609203308909243==" MIME-Version: 1.0 Subject: Re: Review Request 42674: Replaced busybox with alpine in docker tests. From: Timothy Chen To: Jie Yu , Benjamin Hindman , Bernd Mathiske Cc: Timothy Chen , mesos , Guangya Liu , Isabel Jimenez Date: Sat, 23 Jan 2016 01:26:34 -0000 Message-ID: <20160123012634.32315.98812@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Timothy Chen X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42674/ X-Sender: Timothy Chen References: <20160123010034.32314.47300@reviews.apache.org> In-Reply-To: <20160123010034.32314.47300@reviews.apache.org> Reply-To: Timothy Chen X-ReviewRequest-Repository: mesos --===============8697609203308909243== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 23, 2016, 1 a.m., Guangya Liu wrote: > > I saw that many test cases are using busybox, why only updating this one's image? Is it possible to update all busybox to alpine? As the alpine was built around musl libc and BusyBox. The image is only 5 MB in size and has access to a package repository that is much more complete than other BusyBox based images. Hi Guangya, there aren't any tests that I know of still using busybox. If you search for busybox in the tests folder, they are just references and not actually pulling or using the busybox image itself. The intention of this is to replace all busybox images to alpine. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115959 ----------------------------------------------------------- On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42674/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 12:02 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Replaced busybox with alpine in docker tests. > Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7. > Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 > src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b > src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 > src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 > > Diff: https://reviews.apache.org/r/42674/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > > --===============8697609203308909243==--