From reviews-return-21465-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 22 18:37:36 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89500183A4 for ; Fri, 22 Jan 2016 18:37:36 +0000 (UTC) Received: (qmail 31902 invoked by uid 500); 22 Jan 2016 18:37:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31821 invoked by uid 500); 22 Jan 2016 18:37:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31730 invoked by uid 99); 22 Jan 2016 18:37:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 18:37:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CD5A7282FC0; Fri, 22 Jan 2016 18:37:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4844244344018154480==" MIME-Version: 1.0 Subject: Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation. From: "Jie Yu" To: "Jie Yu" , "Michael Park" Cc: "Joris Van Remoortere" , "mesos" Date: Fri, 22 Jan 2016 18:37:29 -0000 Message-ID: <20160122183729.32038.36912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42505/ X-Sender: "Jie Yu" References: <20160122093302.32039.40781@reviews.apache.org> In-Reply-To: <20160122093302.32039.40781@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============4844244344018154480== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/#review115896 ----------------------------------------------------------- Ship it! src/common/resources.cpp (line 685) insert a blank line above? src/common/resources.cpp (line 687) insert a blank line above? src/v1/resources.cpp (line 685) Ditto. src/v1/resources.cpp (line 687) Ditto. - Jie Yu On Jan. 22, 2016, 9:33 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42505/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 9:33 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Repository: mesos > > > Description > ------- > > Multiple Disk: Adjusted DiskInfo validation. > > > Diffs > ----- > > src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a > src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778 > src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc > > Diff: https://reviews.apache.org/r/42505/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > > --===============4844244344018154480==--