From reviews-return-21100-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 20 03:41:00 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 480F518C0E for ; Wed, 20 Jan 2016 03:41:00 +0000 (UTC) Received: (qmail 85292 invoked by uid 500); 20 Jan 2016 03:41:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 85200 invoked by uid 500); 20 Jan 2016 03:41:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 85184 invoked by uid 99); 20 Jan 2016 03:40:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 03:40:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 13D8B282415; Wed, 20 Jan 2016 03:40:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5618157226396855058==" MIME-Version: 1.0 Subject: Re: Review Request 42530: Changed `createReservationInfo` to take `Option`. From: "Greg Mann" To: "Michael Park" Cc: "Greg Mann" , "mesos" Date: Wed, 20 Jan 2016 03:40:58 -0000 Message-ID: <20160120034058.32039.91880@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Greg Mann" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42530/ X-Sender: "Greg Mann" References: <20160120013047.32039.14349@reviews.apache.org> In-Reply-To: <20160120013047.32039.14349@reviews.apache.org> Reply-To: "Greg Mann" X-ReviewRequest-Repository: mesos --===============5618157226396855058== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/ ----------------------------------------------------------- (Updated Jan. 20, 2016, 3:40 a.m.) Review request for mesos and Michael Park. Changes ------- Addressed comment. Repository: mesos Description ------- Changed `createReservationInfo` to take `Option`. Diffs (updated) ----- src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac Diff: https://reviews.apache.org/r/42530/diff/ Testing ------- `make check` on OSX. Thanks, Greg Mann --===============5618157226396855058==--