From reviews-return-21070-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Wed Jan 20 01:40:37 2016
Return-Path: <reviews-return-21070-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5C5E5187E2
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Wed, 20 Jan 2016 01:40:37 +0000 (UTC)
Received: (qmail 80290 invoked by uid 500); 20 Jan 2016 01:40:37 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 80263 invoked by uid 500); 20 Jan 2016 01:40:37 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 80247 invoked by uid 99); 20 Jan 2016 01:40:37 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 01:40:37 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id DC1FB2823EC;
	Wed, 20 Jan 2016 01:40:35 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4557631427906103359=="
MIME-Version: 1.0
Subject: Re: Review Request 42530: Changed `createReservationInfo` to take
 `Option<string>`.
From: "Michael Park" <mpark@apache.org>
To: "Michael Park" <mpark@apache.org>
Cc: "Greg Mann" <greg@mesosphere.io>, "mesos" <reviews@mesos.apache.org>
Date: Wed, 20 Jan 2016 01:40:35 -0000
Message-ID: <20160120014035.7986.89219@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Michael Park" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/42530/
X-Sender: "Michael Park" <noreply@reviews.apache.org>
References: <20160120013047.32039.14349@reviews.apache.org>
In-Reply-To: <20160120013047.32039.14349@reviews.apache.org>
Reply-To: "Michael Park" <mpark@apache.org>
X-ReviewRequest-Repository: mesos

--===============4557631427906103359==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/#review115310
-----------------------------------------------------------



src/tests/mesos.hpp (line 479)
<https://reviews.apache.org/r/42530/#comment176280>

    Oops, sorry. Let's give this a default argument of `None()` here for consistently in style and so that we can do `createReservationInfo()`.


- Michael Park


On Jan. 20, 2016, 1:30 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42530/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed `createReservationInfo` to take `Option<string>`.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
> 
> Diff: https://reviews.apache.org/r/42530/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


--===============4557631427906103359==--