From reviews-return-21069-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 20 01:40:14 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D406B187DF for ; Wed, 20 Jan 2016 01:40:14 +0000 (UTC) Received: (qmail 77994 invoked by uid 500); 20 Jan 2016 01:40:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 77965 invoked by uid 500); 20 Jan 2016 01:40:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77949 invoked by uid 99); 20 Jan 2016 01:40:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 01:40:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6BFED2823EC; Wed, 20 Jan 2016 01:40:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7154576435172474145==" MIME-Version: 1.0 Subject: Re: Review Request 42524: Simplified SchedulerDriver.run(). From: "Greg Mann" To: "Greg Mann" , "Ben Mahler" Cc: "Kevin Klues" , "mesos" Date: Wed, 20 Jan 2016 01:40:13 -0000 Message-ID: <20160120014013.7986.49728@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Greg Mann" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42524/ X-Sender: "Greg Mann" References: <20160119225814.32039.39112@reviews.apache.org> In-Reply-To: <20160119225814.32039.39112@reviews.apache.org> Reply-To: "Greg Mann" X-ReviewRequest-Repository: mesos --===============7154576435172474145== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42524/#review115308 ----------------------------------------------------------- src/sched/sched.cpp (lines 1929 - 1930) Since `join()` returns the current status anyway, could we just do `return join()`? - Greg Mann On Jan. 19, 2016, 10:58 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42524/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 10:58 p.m.) > > > Review request for mesos, Ben Mahler and Greg Mann. > > > Bugs: MESOS-4409 > https://issues.apache.org/jira/browse/MESOS-4409 > > > Repository: mesos > > > Description > ------- > > Previously, the status check in run() was unnecessary due to the short > circuit path in join(). This commit simplifies run() by removing the > check completely. > > > Diffs > ----- > > src/sched/sched.cpp 38940b7e2563a2156be2f8c228afdc27c45b6e83 > > Diff: https://reviews.apache.org/r/42524/diff/ > > > Testing > ------- > > Ran the entire 'make check' suite with no failures on both Mac OS X and ubuntu 14.04. > > > Thanks, > > Kevin Klues > > --===============7154576435172474145==--