From reviews-return-20770-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Jan 17 05:29:04 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76317178A6 for ; Sun, 17 Jan 2016 05:29:04 +0000 (UTC) Received: (qmail 22810 invoked by uid 500); 17 Jan 2016 05:29:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22799 invoked by uid 500); 17 Jan 2016 05:29:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22785 invoked by uid 99); 17 Jan 2016 05:29:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Jan 2016 05:29:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BB524281A57; Sun, 17 Jan 2016 05:29:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2813408015656730933==" MIME-Version: 1.0 Subject: Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports. From: "Ben Mahler" To: "Ben Mahler" Cc: "Shuai Lin" , "mesos" Date: Sun, 17 Jan 2016 05:29:02 -0000 Message-ID: <20160117052902.26792.92104@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42100/ X-Sender: "Ben Mahler" References: <20160109023830.1693.84580@reviews.apache.org> In-Reply-To: <20160109023830.1693.84580@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos --===============2813408015656730933== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review114896 ----------------------------------------------------------- Thanks! Just a small comment below. support/docker_build.sh (lines 125 - 135) Are you sure that this doesn't over-write the period trap? http://stackoverflow.com/questions/3338030/multiple-bash-traps-for-the-same-signal - Ben Mahler On Jan. 9, 2016, 2:38 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42100/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 2:38 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4258 > https://issues.apache.org/jira/browse/MESOS-4258 > > > Repository: mesos > > > Description > ------- > > Updated the jenkins build script to copy out xml testing reports. > > > Diffs > ----- > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > > Diff: https://reviews.apache.org/r/42100/diff/ > > > Testing > ------- > > > Thanks, > > Shuai Lin > > --===============2813408015656730933==--