From reviews-return-20616-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 15 18:49:10 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C99C9186F6 for ; Fri, 15 Jan 2016 18:49:10 +0000 (UTC) Received: (qmail 93168 invoked by uid 500); 15 Jan 2016 18:49:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93141 invoked by uid 500); 15 Jan 2016 18:49:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93117 invoked by uid 99); 15 Jan 2016 18:49:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2016 18:49:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8A7E9281174; Fri, 15 Jan 2016 18:49:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4826097225585328143==" MIME-Version: 1.0 Subject: Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`. From: "Alex Clemmer" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Michael Hopcroft" , "Joseph Wu" Cc: "Alex Naparu" , "Yi Sun" , "Alex Clemmer" , "Michael Park" , "Daniel Pravat" , "mesos" , "Benjamin Bannier" Date: Fri, 15 Jan 2016 18:49:09 -0000 Message-ID: <20160115184909.26386.72541@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alex Clemmer" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39803/ X-Sender: "Alex Clemmer" References: <20160115015804.26792.5837@reviews.apache.org> In-Reply-To: <20160115015804.26792.5837@reviews.apache.org> Reply-To: "Alex Clemmer" X-ReviewRequest-Repository: mesos --===============4826097225585328143== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ ----------------------------------------------------------- (Updated Jan. 15, 2016, 6:49 p.m.) Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description ------- Windows: Implemented stout/os/stat.hpp`. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am ec851dcb08d938defeb6066810011e003d594b29 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp ffe074830ef90f492990bf695e686c885b9a155c 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 5b38b9af654d7d1c574f0cc573083b66693ced1d 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 27edf1b4f8647a2720f2962eafa110d694b3baed Diff: https://reviews.apache.org/r/39803/diff/ Testing ------- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer --===============4826097225585328143==--