From reviews-return-20409-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 14 17:56:06 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95B06189F0 for ; Thu, 14 Jan 2016 17:56:06 +0000 (UTC) Received: (qmail 23688 invoked by uid 500); 14 Jan 2016 17:56:06 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23658 invoked by uid 500); 14 Jan 2016 17:56:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23643 invoked by uid 99); 14 Jan 2016 17:56:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 17:56:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7527B28086B; Thu, 14 Jan 2016 17:56:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2091170576749946698==" MIME-Version: 1.0 Subject: Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available. From: "Kevin Klues" To: "Till Toenshoff" , "Benjamin Bannier" Cc: "Kevin Klues" , "haosdent huang" , "mesos" Date: Thu, 14 Jan 2016 17:56:05 -0000 Message-ID: <20160114175605.26386.38602@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kevin Klues" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42309/ X-Sender: "Kevin Klues" References: <20160114165020.26386.18253@reviews.apache.org> In-Reply-To: <20160114165020.26386.18253@reviews.apache.org> Reply-To: "Kevin Klues" X-ReviewRequest-Repository: mesos --===============2091170576749946698== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/ ----------------------------------------------------------- (Updated Jan. 14, 2016, 5:56 p.m.) Review request for mesos, Benjamin Bannier and Till Toenshoff. Changes ------- Simplify the logic in bootstrap to match that in post-reviews.py Repository: mesos Description ------- The newly introduced way of finding the .git directory via --git-common-dir is only supported on newer versions of git. Fallback to the older --git-dir method if --git-common-dir is not supported. Diffs (updated) ----- bootstrap 519090d696ae09dac70318e91ade583b38f44048 support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44 Diff: https://reviews.apache.org/r/42309/diff/ Testing ------- Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0 repsectively. Thanks, Kevin Klues --===============2091170576749946698==--