From reviews-return-20397-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 14 16:35:22 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8468D182A9 for ; Thu, 14 Jan 2016 16:35:22 +0000 (UTC) Received: (qmail 26516 invoked by uid 500); 14 Jan 2016 16:35:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 26493 invoked by uid 500); 14 Jan 2016 16:35:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26478 invoked by uid 99); 14 Jan 2016 16:35:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 16:35:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 258B4280DE5; Thu, 14 Jan 2016 16:35:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4932638825671511747==" MIME-Version: 1.0 Subject: Re: Review Request 42197: Added a filter for tests using 'perf' hardware events. From: "Mesos ReviewBot" To: "Till Toenshoff" , "Benjamin Bannier" Cc: "Jan Schlicht" , "Mesos ReviewBot" , "mesos" Date: Thu, 14 Jan 2016 16:35:21 -0000 Message-ID: <20160114163521.26792.92466@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42197/ X-Sender: "Mesos ReviewBot" References: <20160114152815.26793.4696@reviews.apache.org> In-Reply-To: <20160114152815.26793.4696@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============4932638825671511747== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114494 ----------------------------------------------------------- Patch looks great! Reviews applied: [42197] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 14, 2016, 3:28 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42197/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 3:28 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-3082 > https://issues.apache.org/jira/browse/MESOS-3082 > > > Repository: mesos > > > Description > ------- > > Virtual machines may not always support 'CPU performance counters'. Tests > trying to collect to 'cycle' value of 'perf' will fail under these > circumstances. This will be avoided by disabling these tests if 'perf' hardware > events are not available. > > > Diffs > ----- > > src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 > > Diff: https://reviews.apache.org/r/42197/diff/ > > > Testing > ------- > > Running `sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Perf:*ROOT_CGROUPS_Sample:*ROOT_CGROUPS_UserCgroup:*CGROUPS_ROOT_PerfRollForward:*ROOT_Sample"` > > 1) In a Linux VM without 'CPU performance counters': This doesn't run the tests and shows an error message that 'cycles' is not available, as expected > 2) In a Linux VM without 'perf': This doesn't run the tests and shows an error message that 'perf' is not installed, as expected > 3) On OSX: This doesn't run the tests and shows an error message that 'perf' is not available, as expected > 4) NOT TESTED YET!!! On native Linux (i.e. with 'CPU performance counters'): This runs the tests. > > > Thanks, > > Jan Schlicht > > --===============4932638825671511747==--