From reviews-return-20194-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 13 17:14:43 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 936C818913 for ; Wed, 13 Jan 2016 17:14:43 +0000 (UTC) Received: (qmail 99825 invoked by uid 500); 13 Jan 2016 17:14:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99808 invoked by uid 500); 13 Jan 2016 17:14:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99786 invoked by uid 99); 13 Jan 2016 17:14:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 17:14:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9999D280DBE; Wed, 13 Jan 2016 17:14:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8406431501708767910==" MIME-Version: 1.0 Subject: Re: Review Request 35711: Disallow special characters in role name. From: "haosdent huang" To: "Adam B" , "Jie Yu" , "Michael Park" Cc: "haosdent huang" , "mesos" , "Klaus Ma" Date: Wed, 13 Jan 2016 17:14:42 -0000 Message-ID: <20160113171442.26793.84318@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "haosdent huang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35711/ X-Sender: "haosdent huang" References: <20160110074426.26792.6203@reviews.apache.org> In-Reply-To: <20160110074426.26792.6203@reviews.apache.org> Reply-To: "haosdent huang" X-ReviewRequest-Repository: mesos --===============8406431501708767910== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 10, 2016, 7:44 a.m., Klaus Ma wrote: > > @klaus1982 @adam-mesos Thank you very much for your detail reviews. Could you help review again? Thank you very much. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113639 ----------------------------------------------------------- On Jan. 13, 2016, 5:12 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 5:12 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/common/roles.cpp PRE-CREATION > src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > > --===============8406431501708767910==--