From reviews-return-20183-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 13 15:22:28 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAABF1824E for ; Wed, 13 Jan 2016 15:22:28 +0000 (UTC) Received: (qmail 36106 invoked by uid 500); 13 Jan 2016 15:22:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36079 invoked by uid 500); 13 Jan 2016 15:22:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36064 invoked by uid 99); 13 Jan 2016 15:22:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 15:22:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BF420280D86; Wed, 13 Jan 2016 15:22:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0929273556563551987==" MIME-Version: 1.0 Subject: Re: Review Request 42221: Removed references to wDRF from allocator. From: "Guangya Liu" To: "Joris Van Remoortere" , "Ben Mahler" Cc: "Guangya Liu" , "Alexander Rukletsov" , "mesos" Date: Wed, 13 Jan 2016 15:22:27 -0000 Message-ID: <20160113152227.26793.4954@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guangya Liu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42221/ X-Sender: "Guangya Liu" References: <20160113015230.26386.82373@reviews.apache.org> In-Reply-To: <20160113015230.26386.82373@reviews.apache.org> Reply-To: "Guangya Liu" X-ReviewRequest-Repository: mesos --===============0929273556563551987== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On 一月 13, 2016, 1:52 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1185 > > > > > > s/framwork/frameworks > > Alexander Rukletsov wrote: > Why do you want plural here? > > Guangya Liu wrote: > It is just typo, I think that we can fix it here as it does not deserve to file another jira to fix it, comments? > > Alexander Rukletsov wrote: > It may be a grammatical mistake, but definitely not a typo: I put singular here on purpose. Only a single framework can accept a resource at a time. Get your point, then how about update to "one of the frameworks"? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114126 ----------------------------------------------------------- On 一月 12, 2016, 11:06 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42221/ > ----------------------------------------------------------- > > (Updated 一月 12, 2016, 11:06 p.m.) > > > Review request for mesos, Ben Mahler and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Since wDRF is encapsulated in the choice of sorter, it should not be > mentioned in the allocator code. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > > Diff: https://reviews.apache.org/r/42221/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > > --===============0929273556563551987==--