From reviews-return-20119-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Wed Jan 13 10:03:34 2016
Return-Path: <reviews-return-20119-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8F04D18526
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Wed, 13 Jan 2016 10:03:34 +0000 (UTC)
Received: (qmail 71986 invoked by uid 500); 13 Jan 2016 10:03:34 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 71960 invoked by uid 500); 13 Jan 2016 10:03:34 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 71943 invoked by uid 99); 13 Jan 2016 10:03:34 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 10:03:34 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 9C8D1280CA1;
	Wed, 13 Jan 2016 10:03:33 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2802894974938621572=="
MIME-Version: 1.0
Subject: Re: Review Request 41876: Used std::list as opposed to List from
 stout.
From: "Alexander Rojas" <alexander@mesosphere.io>
To: "Till Toenshoff" <toenshoff@me.com>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Alexander Rojas" <alexander@mesosphere.io>,
 "Benjamin Bannier" <benjamin.bannier@mesosphere.io>,
 "mesos" <reviews@mesos.apache.org>
Date: Wed, 13 Jan 2016 10:03:33 -0000
Message-ID: <20160113100333.26792.87114@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Alexander Rojas" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/41876/
X-Sender: "Alexander Rojas" <noreply@reviews.apache.org>
References: <20160113100242.26792.19790@reviews.apache.org>
In-Reply-To: <20160113100242.26792.19790@reviews.apache.org>
Reply-To: "Alexander Rojas" <alexander@mesosphere.io>
X-ReviewRequest-Repository: mesos

--===============2802894974938621572==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41876/#review114169
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rojas


On Jan. 13, 2016, 11:02 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41876/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:02 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-4273
>     https://issues.apache.org/jira/browse/MESOS-4273
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> List from stout provides no advantage over std::list now that C++11 is
> available.
> 
> Review: https://reviews.apache.org/r/41876
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 8f0a31341eebb168f78bc74f8afbaef9ba98e847 
>   3rdparty/libprocess/src/tests/timeseries_tests.cpp 274598e63d28150aaa0ad06fa2d85e41e525c153 
> 
> Diff: https://reviews.apache.org/r/41876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


--===============2802894974938621572==--