From reviews-return-20097-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jan 13 05:08:18 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DBDC18B0A for ; Wed, 13 Jan 2016 05:08:18 +0000 (UTC) Received: (qmail 73078 invoked by uid 500); 13 Jan 2016 05:08:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 72978 invoked by uid 500); 13 Jan 2016 05:08:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72965 invoked by uid 99); 13 Jan 2016 05:08:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 05:08:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 47D1F280C82; Wed, 13 Jan 2016 05:08:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2480571942930332882==" MIME-Version: 1.0 Subject: Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses. From: "Mesos ReviewBot" To: "Adam B" Cc: "Neil Conway" , "Mesos ReviewBot" , "mesos" Date: Wed, 13 Jan 2016 05:08:17 -0000 Message-ID: <20160113050817.26386.92193@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41806/ X-Sender: "Mesos ReviewBot" References: <20160112204724.26792.17441@reviews.apache.org> In-Reply-To: <20160112204724.26792.17441@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============2480571942930332882== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114148 ----------------------------------------------------------- Patch looks great! Reviews applied: [41806] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 12, 2016, 8:47 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41806/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 8:47 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > ------- > > Used `AWAIT_EXPECT_RESPONSE_HEADER_EQ()` to check the "Content-Type" of > the response, rather than accessing the "headers" field directly, and > used the symbol `APPLICATION_JSON` rather than a string literal. Also > added "Content-Type" checks to a few places that had neglected to make > them, and cleaned up some whitespace style. > > > Diffs > ----- > > src/tests/executor_http_api_tests.cpp 952aacb720715ad26f91fa08bc386b242b7e007b > src/tests/fault_tolerance_tests.cpp fd1c3c90101eed9ef9352511e0c72a463cca965c > src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 > src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 > src/tests/monitor_tests.cpp a848d14ebb6cab79c06bcf55bd39f044b41a006e > src/tests/repair_tests.cpp 63ec889c4954c2c60d3466952551aa25b3284ddf > src/tests/scheduler_driver_tests.cpp 1365d21ccad87923b862fb4942f1fd51630a62b7 > src/tests/scheduler_http_api_tests.cpp 4d23a5a8368e0ed126469fa4a90a889b339ad004 > src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 > src/tests/status_update_manager_tests.cpp bd34b97a3559a5fea9a7a253a89e0ac3029f4a33 > src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b > > Diff: https://reviews.apache.org/r/41806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > > --===============2480571942930332882==--