----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/#review114033 ----------------------------------------------------------- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 41791, 42113, 42194] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 12, 2016, 2:54 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42194/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 2:54 p.m.) > > > Review request for mesos and Klaus Ma. > > > Repository: mesos > > > Description > ------- > > Handle unreserve logic for dynamic reservation with allocation slack. > > This patch is halding the case when using updateAvailable to unreserve > some resources. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/42194/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >