From reviews-return-20005-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 12 18:38:41 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57B5118C2F for ; Tue, 12 Jan 2016 18:38:41 +0000 (UTC) Received: (qmail 35529 invoked by uid 500); 12 Jan 2016 18:38:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 35496 invoked by uid 500); 12 Jan 2016 18:38:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 35481 invoked by uid 99); 12 Jan 2016 18:38:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 18:38:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8215B1D9C47; Tue, 12 Jan 2016 18:38:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8710986982965762765==" MIME-Version: 1.0 Subject: Re: Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (2/2). From: "Mesos ReviewBot" To: "Klaus Ma" Cc: "Guangya Liu" , "Mesos ReviewBot" , "mesos" Date: Tue, 12 Jan 2016 18:38:40 -0000 Message-ID: <20160112183840.26792.88850@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42194/ X-Sender: "Mesos ReviewBot" References: <20160112145448.26386.67103@reviews.apache.org> In-Reply-To: <20160112145448.26386.67103@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============8710986982965762765== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/#review114033 ----------------------------------------------------------- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 41791, 42113, 42194] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 12, 2016, 2:54 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42194/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 2:54 p.m.) > > > Review request for mesos and Klaus Ma. > > > Repository: mesos > > > Description > ------- > > Handle unreserve logic for dynamic reservation with allocation slack. > > This patch is halding the case when using updateAvailable to unreserve > some resources. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/42194/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > > --===============8710986982965762765==--