From reviews-return-19992-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 12 17:33:07 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7CD89188EB for ; Tue, 12 Jan 2016 17:33:07 +0000 (UTC) Received: (qmail 11934 invoked by uid 500); 12 Jan 2016 17:33:07 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 11905 invoked by uid 500); 12 Jan 2016 17:33:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 11889 invoked by uid 99); 12 Jan 2016 17:33:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 17:33:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6822D1D9C47; Tue, 12 Jan 2016 17:33:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1733297988877524841==" MIME-Version: 1.0 Subject: Re: Review Request 41275: Introduced a field for specifying grace period in shutdown event. From: "Anand Mazumdar" To: "Vinod Kone" , "Ben Mahler" Cc: "Joseph Wu" , "Qian Zhang" , "mesos" , "Anand Mazumdar" Date: Tue, 12 Jan 2016 17:33:06 -0000 Message-ID: <20160112173306.26792.30655@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Anand Mazumdar" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41275/ X-Sender: "Anand Mazumdar" References: <20160112172900.26792.60434@reviews.apache.org> In-Reply-To: <20160112172900.26792.60434@reviews.apache.org> Reply-To: "Anand Mazumdar" X-ReviewRequest-Repository: mesos --===============1733297988877524841== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/ ----------------------------------------------------------- (Updated Jan. 12, 2016, 5:33 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes ------- Modified summary to be smaller then magical `72` characters. Summary (updated) ----------------- Introduced a field for specifying grace period in shutdown event. Bugs: MESOS-3550 https://issues.apache.org/jira/browse/MESOS-3550 Repository: mesos Description ------- This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container. Diffs ----- include/mesos/executor/executor.proto cc6b4f67da62dacf2fc649f00ba15a3fba98910b include/mesos/v1/executor/executor.proto 4ecdaa0a468da1b271aa382a945d7e2a59c32449 Diff: https://reviews.apache.org/r/41275/diff/ Testing ------- make check Thanks, Anand Mazumdar --===============1733297988877524841==--