From reviews-return-19902-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 12 01:24:43 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DF151829C for ; Tue, 12 Jan 2016 01:24:43 +0000 (UTC) Received: (qmail 39724 invoked by uid 500); 12 Jan 2016 01:24:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 39705 invoked by uid 500); 12 Jan 2016 01:24:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 39684 invoked by uid 99); 12 Jan 2016 01:24:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 01:24:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C0FFF28077E; Tue, 12 Jan 2016 01:24:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2890887222625398624==" MIME-Version: 1.0 Subject: Re: Review Request 42167: Fixed stout protobuf::parse passing error message in nested JSON. From: "Joseph Wu" To: "Joseph Wu" , "Artem Harutyunyan" , "Jie Yu" , "Joris Van Remoortere" , "Ben Mahler" , "Timothy Chen" Cc: "Gilbert Song" , "mesos" Date: Tue, 12 Jan 2016 01:24:42 -0000 Message-ID: <20160112012442.26793.65901@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joseph Wu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42167/ X-Sender: "Joseph Wu" References: <20160111233908.26386.75941@reviews.apache.org> In-Reply-To: <20160111233908.26386.75941@reviews.apache.org> Reply-To: "Joseph Wu" X-ReviewRequest-Repository: mesos --===============2890887222625398624== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42167/#review113894 ----------------------------------------------------------- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 336) s/for recursive/for the recursive/ s/sequencially/sequentially/ 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 339 - 346) Wouldn't it be simpler to do this? `return parse(reflection->AddMessage(message, field), object);` The return types are the same. Ditto for the `else`. - Joseph Wu On Jan. 11, 2016, 3:39 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42167/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 3:39 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Joseph Wu, and Timothy Chen. > > > Bugs: MESOS-4311 > https://issues.apache.org/jira/browse/MESOS-4311 > > > Repository: mesos > > > Description > ------- > > Fixed stout protobuf::parse passing error message in nested JSON. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 > > Diff: https://reviews.apache.org/r/42167/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > > --===============2890887222625398624==--