From reviews-return-19866-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 11 22:19:52 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BDD21893C for ; Mon, 11 Jan 2016 22:19:52 +0000 (UTC) Received: (qmail 20050 invoked by uid 500); 11 Jan 2016 22:19:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 20027 invoked by uid 500); 11 Jan 2016 22:19:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20009 invoked by uid 99); 11 Jan 2016 22:19:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 22:19:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 79B162806EC; Mon, 11 Jan 2016 22:19:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8371363914392555445==" MIME-Version: 1.0 Subject: Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems. From: "Alex Clemmer" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Joseph Wu" , "Daniel Pravat" , "Alex Naparu" Cc: "Alex Clemmer" , "mesos" , "Mesos ReviewBot" Date: Mon, 11 Jan 2016 22:19:51 -0000 Message-ID: <20160111221951.26793.85738@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alex Clemmer" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39019/ X-Sender: "Alex Clemmer" References: <20160111220317.26792.63296@reviews.apache.org> In-Reply-To: <20160111220317.26792.63296@reviews.apache.org> Reply-To: "Alex Clemmer" X-ReviewRequest-Repository: mesos --===============8371363914392555445== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ ----------------------------------------------------------- (Updated Jan. 11, 2016, 10:19 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3441 https://issues.apache.org/jira/browse/MESOS-3441 Repository: mesos Description ------- Windows: Added dirent compat code for non-Unix systems. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd Diff: https://reviews.apache.org/r/39019/diff/ Testing ------- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer --===============8371363914392555445==--