From reviews-return-19806-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 11 15:41:38 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C8FC5184D6 for ; Mon, 11 Jan 2016 15:41:38 +0000 (UTC) Received: (qmail 3266 invoked by uid 500); 11 Jan 2016 15:41:38 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 3241 invoked by uid 500); 11 Jan 2016 15:41:38 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 3224 invoked by uid 99); 11 Jan 2016 15:41:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 15:41:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8E8A6280308; Mon, 11 Jan 2016 15:41:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3408686083349305321==" MIME-Version: 1.0 Subject: Re: Review Request 42140: Removed deprecated constructor of http::Unauthorized in libprocess. From: "Alexander Rojas" To: "Till Toenshoff" , "Ben Mahler" , "Benjamin Bannier" , "Jan Schlicht" Cc: "mesos" , "Alexander Rojas" Date: Mon, 11 Jan 2016 15:41:35 -0000 Message-ID: <20160111154135.26793.16319@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rojas" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42140/ X-Sender: "Alexander Rojas" References: <20160111150316.26792.55166@reviews.apache.org> In-Reply-To: <20160111150316.26792.55166@reviews.apache.org> Reply-To: "Alexander Rojas" X-ReviewRequest-Repository: mesos --===============3408686083349305321== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42140/ ----------------------------------------------------------- (Updated Jan. 11, 2016, 4:41 p.m.) Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff. Changes ------- Benjamin's review. Bugs: MESOS-3933 and MESOS-4305 https://issues.apache.org/jira/browse/MESOS-3933 https://issues.apache.org/jira/browse/MESOS-4305 Repository: mesos Description ------- The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase. This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector&)` constructor since there is no longer an ambiguity. Diffs (updated) ----- src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132 src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae Diff: https://reviews.apache.org/r/42140/diff/ Testing ------- make check Thanks, Alexander Rojas --===============3408686083349305321==--