From reviews-return-19764-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 11 11:29:22 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C036E18A3F for ; Mon, 11 Jan 2016 11:29:22 +0000 (UTC) Received: (qmail 20717 invoked by uid 500); 11 Jan 2016 11:29:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 20699 invoked by uid 500); 11 Jan 2016 11:29:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20377 invoked by uid 99); 11 Jan 2016 11:29:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 11:29:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A88971D2740; Mon, 11 Jan 2016 11:29:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7363563033627642460==" MIME-Version: 1.0 Subject: Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`. From: "Alex Clemmer" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Joseph Wu" Cc: "mesos" , "Alex Clemmer" , "Yi Sun" Date: Mon, 11 Jan 2016 11:29:20 -0000 Message-ID: <20160111112920.26793.99450@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alex Clemmer" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39802/ X-Sender: "Alex Clemmer" References: <20160109010515.1693.72956@reviews.apache.org> In-Reply-To: <20160109010515.1693.72956@reviews.apache.org> Reply-To: "Alex Clemmer" X-ReviewRequest-Repository: mesos --===============7363563033627642460== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 9, 2016, 1:05 a.m., Yi Sun wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, line 55 > > > > > > So the entry is always pointing to the allocated memory when success. Following up from our Slack conversation where I clarified your question: `entry` actually points at the current directory entry of `dir`, so a call to free is not necessary here. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113581 ----------------------------------------------------------- On Jan. 4, 2016, 11:20 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39802/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:20 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `stout/os/windows/ls.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ls.hpp 7dba79d31559d15a3e84eff506ce7df3e57cf5f3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp 5b6fba13ce215af5801fd0867f6e774e100689ca > > Diff: https://reviews.apache.org/r/39802/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > > --===============7363563033627642460==--