From reviews-return-19758-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 11 10:51:34 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0984F188E5 for ; Mon, 11 Jan 2016 10:51:34 +0000 (UTC) Received: (qmail 66142 invoked by uid 500); 11 Jan 2016 10:51:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 66119 invoked by uid 500); 11 Jan 2016 10:51:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 66097 invoked by uid 99); 11 Jan 2016 10:51:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 10:51:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 514431D2740; Mon, 11 Jan 2016 10:51:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2358489573035459739==" MIME-Version: 1.0 Subject: Re: Review Request 42040: Added Quota Operator Documentation. From: "Joerg Schad" To: "Joris Van Remoortere" , "Alexander Rukletsov" , "Neil Conway" , "Bernd Mathiske" Cc: "mesos" , "Joerg Schad" Date: Mon, 11 Jan 2016 10:51:33 -0000 Message-ID: <20160111105133.26792.4257@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joerg Schad" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42040/ X-Sender: "Joerg Schad" References: <20160107235552.1209.41394@reviews.apache.org> In-Reply-To: <20160107235552.1209.41394@reviews.apache.org> Reply-To: "Joerg Schad" X-ReviewRequest-Repository: mesos --===============2358489573035459739== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 61 > > > > > > These kinds of implementation details belong at the bottom of the document, I think -- it is more important to tell the user/operator how to define quota before we worry about allocator details. > > > > We could also remove a lot of this information -- the specific steps we take to implement a set/remove quota request are not an important thing to document (and might change over time). > > Alexander Rukletsov wrote: > Our intention was *not* to provide implementation details, but to mention some of those, which are important and affect cluster behaviour. There are 3 things: capacity heuristic, rescinding offers, allocator logic (quota first, fair share second). I do think we should explain operators how these things work so that they don't break their clusters. > > However, if the section feels like an "implementation details" section, we didn't achieve our goal. The reason we decided to briefly mention other stages is in order not to be misleading and leave an impression, that there is nothing else. > > Do you think leaving only these 3 sections and adding a sentence that those are most important stages in quota processing is a good compromise? > > Neil Conway wrote: > I think we could improve things in two ways: > > 1. Move the "How does it work?" section to the end of the document. Although this is useful material, it is fairly advanced; a lot of users will want to just know how to configure/examine quota. > 2. Remove some of the implementation details. For example, the fact that we authenticate, parse, validate, and authorize a quota request is not important for the information we want to convey to operators about how quotas behave. IMO all steps (except inform allocator, which I agree can be dropped) have potential implication for the operator as he might receive error relating to each stage or it influences the behavior of the cluster (failover & rescinding). - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113358 ----------------------------------------------------------- On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42040/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 10:26 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway. > > > Bugs: MESOS-3877 > https://issues.apache.org/jira/browse/MESOS-3877 > > > Repository: mesos > > > Description > ------- > > Added Quota Operator Documentation. > > > Diffs > ----- > > docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 > docs/quota.md PRE-CREATION > > Diff: https://reviews.apache.org/r/42040/diff/ > > > Testing > ------- > > Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56 > > > Thanks, > > Joerg Schad > > --===============2358489573035459739==--