From reviews-return-19734-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 11 03:44:56 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6567318AC7 for ; Mon, 11 Jan 2016 03:44:56 +0000 (UTC) Received: (qmail 3525 invoked by uid 500); 11 Jan 2016 03:44:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 3497 invoked by uid 500); 11 Jan 2016 03:44:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 3481 invoked by uid 99); 11 Jan 2016 03:44:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 03:44:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 771642803DD; Mon, 11 Jan 2016 03:44:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2329518051433836619==" MIME-Version: 1.0 Subject: Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. From: "Mesos ReviewBot" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Ben Mahler" Cc: "Joseph Wu" , "mesos" , "Mesos ReviewBot" Date: Mon, 11 Jan 2016 03:44:55 -0000 Message-ID: <20160111034455.26793.29913@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42086/ X-Sender: "Mesos ReviewBot" References: <20160109015803.1693.82834@reviews.apache.org> In-Reply-To: <20160109015803.1693.82834@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============2329518051433836619== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113672 ----------------------------------------------------------- Patch looks great! Reviews applied: [42092, 42086] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 9, 2016, 1:58 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42086/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 1:58 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere. > > > Bugs: MESOS-4301 > https://issues.apache.org/jira/browse/MESOS-4301 > > > Repository: mesos > > > Description > ------- > > Adds `validation::offer::inverse::validate` to validate inverse offers along the same lines as `validation::offer::validate`, except `SlaveId` is not validated for inverse offers. > > Fixes and refactors `Master::accept` to allow `ACCEPT` calls that contain both offers and inverse offers. > Also tweaks `Master::accept` to not print a misleading log line "ACCEPT call used invalid offers ..." when the call only includes inverse offers. > > > Diffs > ----- > > include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a > src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 > src/master/master.hpp f02d165874fa8023675e545793de699aeecae29b > src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 > src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c > src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 > > Diff: https://reviews.apache.org/r/42086/diff/ > > > Testing > ------- > > make check > > # Ran the following and checked for blank output: > bin/mesos-tests.sh --gtest_filter="*Inverse*Offer*" --verbose 2>&1 /dev/null | grep "ACCEPT call used invalid offers" > > # Check new test for flakiness: > bin/mesos-tests.sh --gtest_filter="*OffersAndInverseOffers" --gtest_repeat=1500 --gtest_break_on_failure > > > Thanks, > > Joseph Wu > > --===============2329518051433836619==--