From reviews-return-19652-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 8 22:07:25 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D02918A5B for ; Fri, 8 Jan 2016 22:07:25 +0000 (UTC) Received: (qmail 35545 invoked by uid 500); 8 Jan 2016 22:07:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 35537 invoked by uid 500); 8 Jan 2016 22:07:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 35517 invoked by uid 99); 8 Jan 2016 22:07:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 22:07:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 869291DBF7B; Fri, 8 Jan 2016 22:07:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3596063421121222333==" MIME-Version: 1.0 Subject: Re: Review Request 41461: Added SFINAE-friendly `result_of` to stout. From: "Michael Park" To: "Joris Van Remoortere" , "Benjamin Hindman" , "Alex Clemmer" Cc: "Michael Park" , "mesos" , "Alexander Rukletsov" , "Alexander Rojas" Date: Fri, 08 Jan 2016 22:07:24 -0000 Message-ID: <20160108220724.1693.6402@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Michael Park" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41461/ X-Sender: "Michael Park" References: <20160106021241.26044.53502@reviews.apache.org> In-Reply-To: <20160106021241.26044.53502@reviews.apache.org> Reply-To: "Michael Park" X-ReviewRequest-Repository: mesos --===============3596063421121222333== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ ----------------------------------------------------------- (Updated Jan. 8, 2016, 10:07 p.m.) Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van Remoortere. Changes ------- Addressed BenH's offline comments. Bugs: MESOS-4220 https://issues.apache.org/jira/browse/MESOS-4220 Repository: mesos Description ------- VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so `result_of` must be replaced with `decltype(invoke)`. Here, we implement SFINAE `result_of` in `stout`. Follow-up from [r40114](https://reviews.apache.org/r/40114/). Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41461/diff/ Testing ------- `make check` on OS X, compiled on Windows. Thanks, Michael Park --===============3596063421121222333==--