From reviews-return-19608-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 8 16:43:45 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4C17187EE for ; Fri, 8 Jan 2016 16:43:45 +0000 (UTC) Received: (qmail 70849 invoked by uid 500); 8 Jan 2016 16:43:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70827 invoked by uid 500); 8 Jan 2016 16:43:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70810 invoked by uid 99); 8 Jan 2016 16:43:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 16:43:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 263941CCB18; Fri, 8 Jan 2016 16:43:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0749091112621825617==" MIME-Version: 1.0 Subject: Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory. From: "Mesos ReviewBot" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Alex Clemmer" , "Joseph Wu" Cc: "Diana Arroyo" , "mesos" , "Mesos ReviewBot" Date: Fri, 08 Jan 2016 16:43:45 -0000 Message-ID: <20160108164345.1692.85297@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41108/ X-Sender: "Mesos ReviewBot" References: <20160108152902.1693.39476@reviews.apache.org> In-Reply-To: <20160108152902.1693.39476@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============0749091112621825617== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review113487 ----------------------------------------------------------- Bad patch! Reviews applied: [41096, 41185, 41108] Failed command: ./support/apply-review.sh -n -r 41108 Error: 2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ [4052/4052] -> "41108.patch" [1] error: patch failed: src/slave/cmake/FindCurl.cmake:31 error: src/slave/cmake/FindCurl.cmake: patch does not apply - Mesos ReviewBot On Jan. 8, 2016, 3:29 p.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41108/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 3:29 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cmake/FindCurl.cmake PRE-CREATION > src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41108/diff/ > > > Testing > ------- > > Tested on Ubuntu and OSX. > Tested if and else path of new logic added to FindCurl.cmake. > > > Thanks, > > Diana Arroyo > > --===============0749091112621825617==--