From reviews-return-19587-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 8 12:40:58 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 79D1B17DA1 for ; Fri, 8 Jan 2016 12:40:58 +0000 (UTC) Received: (qmail 60018 invoked by uid 500); 8 Jan 2016 12:40:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 59995 invoked by uid 500); 8 Jan 2016 12:40:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 59980 invoked by uid 99); 8 Jan 2016 12:40:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 12:40:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 003041CCB18; Fri, 8 Jan 2016 12:40:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3593890967794927571==" MIME-Version: 1.0 Subject: Re: Review Request 41597: Extending allocator interface to support dynamic weights. From: "Yongqiao Wang" To: "Adam B" , "Neil Conway" , "Qian Zhang" Cc: "Yongqiao Wang" , "Mesos ReviewBot" , "mesos" Date: Fri, 08 Jan 2016 12:40:57 -0000 Message-ID: <20160108124057.1693.81791@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yongqiao Wang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41597/ X-Sender: "Yongqiao Wang" References: <20160106110134.26044.33169@reviews.apache.org> In-Reply-To: <20160106110134.26044.33169@reviews.apache.org> Reply-To: "Yongqiao Wang" X-ReviewRequest-Repository: mesos --===============3593890967794927571== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ ----------------------------------------------------------- (Updated Jan. 8, 2016, 12:40 p.m.) Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Changes ------- Rebase. Bugs: MESOS-3943 https://issues.apache.org/jira/browse/MESOS-3943 Repository: mesos Description ------- Add the interface in allocator to support updating weight at runtime, and the allocator is invoked to allocate the resources based on the updated weights later. Diffs (updated) ----- include/mesos/master/allocator.hpp fcebcab71c50a725ca4e635c03c29eed2a406bc3 include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 src/master/allocator/mesos/allocator.hpp 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08 src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824 src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef Diff: https://reviews.apache.org/r/41597/diff/ Testing ------- Make & Make check successfully! Test case: https://reviews.apache.org/r/41672/ Thanks, Yongqiao Wang --===============3593890967794927571==--