From reviews-return-19496-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 8 00:05:25 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B96A11831A for ; Fri, 8 Jan 2016 00:05:25 +0000 (UTC) Received: (qmail 47307 invoked by uid 500); 8 Jan 2016 00:05:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47288 invoked by uid 500); 8 Jan 2016 00:05:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47173 invoked by uid 99); 8 Jan 2016 00:05:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 00:05:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 34D68298CCB; Fri, 8 Jan 2016 00:05:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3699162498754476830==" MIME-Version: 1.0 Subject: Re: Review Request 41816: Generated ContainerConfig in mesos containerizer. From: "Jie Yu" To: "Artem Harutyunyan" , "Timothy Chen" , "Jie Yu" Cc: "Gilbert Song" , "mesos" Date: Fri, 08 Jan 2016 00:05:25 -0000 Message-ID: <20160108000525.26044.6183@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41816/ X-Sender: "Jie Yu" References: <20160106234058.26043.18654@reviews.apache.org> In-Reply-To: <20160106234058.26043.18654@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============3699162498754476830== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41816/#review113366 ----------------------------------------------------------- src/slave/containerizer/mesos/containerizer.cpp (lines 693 - 702) You are constructing a `containerConfig` for each isolator! I would construct `containerConfig` in `prepare` and pass it to `_prepare`. We can remove 'directory' and 'user' parameters in `_prepare` later as it's already in `containerConfig`. - Jie Yu On Jan. 6, 2016, 11:40 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41816/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 11:40 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4240 > https://issues.apache.org/jira/browse/MESOS-4240 > > > Repository: mesos > > > Description > ------- > > Generated ContainerConfig in mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp 89d18624b08f2c953b9fa21663aeda694d4aac12 > src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0 > > Diff: https://reviews.apache.org/r/41816/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > > --===============3699162498754476830==--