From reviews-return-19465-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 7 20:29:33 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E5D5187A4 for ; Thu, 7 Jan 2016 20:29:33 +0000 (UTC) Received: (qmail 36940 invoked by uid 500); 7 Jan 2016 20:29:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36917 invoked by uid 500); 7 Jan 2016 20:29:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36896 invoked by uid 99); 7 Jan 2016 20:29:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 20:29:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DDF04298BCB; Thu, 7 Jan 2016 20:29:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1825026798046847861==" MIME-Version: 1.0 Subject: Re: Review Request 42025: Added flag for enabling HTTP authentication. From: "Till Toenshoff" To: "Adam B" , "Bernd Mathiske" , "Vinod Kone" , "Ben Mahler" , "Alexander Rojas" , "Jan Schlicht" Cc: "Joerg Schad" , "mesos" , "Till Toenshoff" , "Mesos ReviewBot" Date: Thu, 07 Jan 2016 20:29:32 -0000 Message-ID: <20160107202932.26043.75027@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Till Toenshoff" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42025/ X-Sender: "Till Toenshoff" References: <20160107191220.26043.56018@reviews.apache.org> In-Reply-To: <20160107191220.26043.56018@reviews.apache.org> Reply-To: "Till Toenshoff" X-ReviewRequest-Repository: mesos --===============1825026798046847861== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/ ----------------------------------------------------------- (Updated Jan. 7, 2016, 8:29 p.m.) Review request for mesos, Adam B, Alexander Rojas, Bernd Mathiske, Ben Mahler, Jan Schlicht, and Vinod Kone. Changes ------- Addressed Joergs comments. Bugs: MESOS-3024 https://issues.apache.org/jira/browse/MESOS-3024 Repository: mesos Description ------- Adds new `authenticate_http` flag to the master. Also updates some tests that were using the credentials for de/activating HTTP authentication. Diffs (updated) ----- docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 src/master/flags.cpp f864419a6276356c97a0a4fe29e5cfce6c4660c4 src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 src/tests/master_quota_tests.cpp bc8a117982b994279e0df7639b21abaeb308b76d src/tests/mesos.cpp 3867ed2fcb197f98f0a19ca37ed81392db27e8a0 Diff: https://reviews.apache.org/r/42025/diff/ Testing ------- make check functional testing by playing with the framework shutdown endpoint (teardown). --- ./bin/mesos-master.sh --work_dir=/tmp --authenticate_http -> fails with "No credentials provided for the default 'basic' HTTP authenticator." ---- ./bin/mesos-master.sh --work_dir=/tmp --authenticate_http --credentials=file://some_valid_file ./src/test-framework --master=127.0.0.1:5050 curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v -> fails with "HTTP/1.1 401 Unauthorized" curl --user invalid:credentials --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v -> fails with "HTTP/1.1 401 Unauthorized" curl --user valid:credentials --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v -> succeeds with "HTTP/1.1 200 OK" ---- ./bin/mesos-master.sh --work_dir=/tmp --credentials=file://some_valid_file ./src/test-framework --master=127.0.0.1:5050 curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v -> succeeds with "HTTP/1.1 200 OK" curl --user some:credentials --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v -> succeeds with "HTTP/1.1 200 OK" Thanks, Till Toenshoff --===============1825026798046847861==--