From reviews-return-19430-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 7 17:19:31 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC6A118BCE for ; Thu, 7 Jan 2016 17:19:31 +0000 (UTC) Received: (qmail 66472 invoked by uid 500); 7 Jan 2016 17:19:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 66447 invoked by uid 500); 7 Jan 2016 17:19:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 66354 invoked by uid 99); 7 Jan 2016 17:19:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 17:19:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 45F0329826F; Thu, 7 Jan 2016 17:19:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0430795833856839748==" MIME-Version: 1.0 Subject: Re: Review Request 39043: Added support for HTTP Authentication in Mesos. From: "Greg Mann" To: "Isabel Jimenez" , "Adam B" , "Bernd Mathiske" , "Till Toenshoff" , "Jan Schlicht" Cc: "mesos" , "Greg Mann" , "Alexander Rojas" Date: Thu, 07 Jan 2016 17:19:31 -0000 Message-ID: <20160107171931.26044.37201@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Greg Mann" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39043/ X-Sender: "Greg Mann" References: <20160107164143.26043.36554@reviews.apache.org> In-Reply-To: <20160107164143.26043.36554@reviews.apache.org> Reply-To: "Greg Mann" X-ReviewRequest-Repository: mesos --===============0430795833856839748== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113276 ----------------------------------------------------------- Ship it! Ship It! - Greg Mann On Jan. 7, 2016, 4:41 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39043/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 4:41 p.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3756 and MESOS-4149 > https://issues.apache.org/jira/browse/MESOS-3756 > https://issues.apache.org/jira/browse/MESOS-4149 > > > Repository: mesos > > > Description > ------- > > 1. Adds a flag to load an HTTP Authenticator module from the flags. > 2. If provided, uses the credentials file to initialize the default HTTP Authenticator. > 3. Updates the existing endpoints which implement their own basic HTTP authenticator with the libprocess one. > 4. Updates one test which expected the wrong results since now credentials are checked before the body of the request. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION > src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION > src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 > src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp f864419a6276356c97a0a4fe29e5cfce6c4660c4 > src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 > src/master/master.hpp f764915ff8bbf74b99a617e3c4735d38fc13e5f0 > src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 > src/master/quota_handler.cpp 93960f3728f9e68c085e6009fe975542d29d2551 > src/tests/master_quota_tests.cpp bc8a117982b994279e0df7639b21abaeb308b76d > src/tests/mesos.cpp 3867ed2fcb197f98f0a19ca37ed81392db27e8a0 > > Diff: https://reviews.apache.org/r/39043/diff/ > > > Testing > ------- > > ```bash > # On OS X 10.11.2 and Ubuntu 14.04.3 > $ make check > $ ./bin/mesos-tests.sh --gtest_repeat=50 --gtest_shuffle --gtest_break_on_failure > > # On Ubuntu 14.04.3 (Disabling known flaky tests) > $ sudo ./bin/mesos-tests.sh --gtest_repeat=50 --gtest_shuffle --gtest_break_on_failure \ > --gtest_filter="-*.ROOT_IncreaseRSS:*.ROOT_CGROUPS_Listen" > ``` > > > Thanks, > > Alexander Rojas > > --===============0430795833856839748==--