From reviews-return-19326-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 7 01:48:16 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AB5A182D2 for ; Thu, 7 Jan 2016 01:48:16 +0000 (UTC) Received: (qmail 74492 invoked by uid 500); 7 Jan 2016 01:48:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74473 invoked by uid 500); 7 Jan 2016 01:48:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74458 invoked by uid 99); 7 Jan 2016 01:48:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 01:48:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5E253298993; Thu, 7 Jan 2016 01:48:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0810107892603108235==" MIME-Version: 1.0 Subject: Re: Review Request 42002: Updated missing allocator comments and removed redundancies. From: "Guangya Liu" To: "Guangya Liu" , "Alexander Rukletsov" , "Neil Conway" Cc: "Adam B" , "mesos" Date: Thu, 07 Jan 2016 01:48:14 -0000 Message-ID: <20160107014814.26044.76442@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guangya Liu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42002/ X-Sender: "Guangya Liu" References: <20160107004710.26044.85583@reviews.apache.org> In-Reply-To: <20160107004710.26044.85583@reviews.apache.org> Reply-To: "Guangya Liu" X-ReviewRequest-Repository: mesos --===============0810107892603108235== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42002/#review113161 ----------------------------------------------------------- include/mesos/master/allocator.hpp (line 73) does this still needed? include/mesos/master/allocator.hpp (line 268) s/slave/agent Seems this file is using agent instead of slave. - Guangya Liu On 一月 7, 2016, 12:47 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42002/ > ----------------------------------------------------------- > > (Updated 一月 7, 2016, 12:47 a.m.) > > > Review request for mesos, Alexander Rukletsov, Guangya Liu, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Updated missing allocator comments and removed redundancies. > > > Diffs > ----- > > include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb33333d6 > > Diff: https://reviews.apache.org/r/42002/diff/ > > > Testing > ------- > > JAVADOC_AUTOBRIEF=YES means that the brief description stops at the first '.', so we don't really need a newline or blank line in between brief and detailed descriptions. > Also, REPEAT_BRIEF=YES means that the brief description is prepended to the detailed description, so there's no need to repeat it ourselves. > > I mostly wanted to get rid of gyliu513's TODOs, but got frustrated with the useless comment : function definition ratio. > > > Thanks, > > Adam B > > --===============0810107892603108235==--