From reviews-return-18937-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org  Tue Jan  5 01:07:03 2016
Return-Path: <reviews-return-18937-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AD2A61832A
	for <apmail-mesos-reviews-archive@minotaur.apache.org>; Tue,  5 Jan 2016 01:07:03 +0000 (UTC)
Received: (qmail 98193 invoked by uid 500); 5 Jan 2016 01:07:03 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 98168 invoked by uid 500); 5 Jan 2016 01:07:03 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 98147 invoked by uid 99); 5 Jan 2016 01:07:03 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 01:07:03 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 13A24297D3C;
	Tue,  5 Jan 2016 01:07:02 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============3358893543636397966=="
MIME-Version: 1.0
Subject: Re: Review Request 41909: Fixed posix filesystem isolator to not allow
 executors with image.
From: "Gilbert Song" <songzihao1990@gmail.com>
To: "Jie Yu" <yujie.jay@gmail.com>
Cc: "Gilbert Song" <songzihao1990@gmail.com>,
 "Timothy Chen" <tnachen@apache.org>, "mesos" <reviews@mesos.apache.org>
Date: Tue, 05 Jan 2016 01:07:02 -0000
Message-ID: <20160105010702.26043.56015@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Gilbert Song" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/41909/
X-Sender: "Gilbert Song" <noreply@reviews.apache.org>
References: <20160105010600.26044.30527@reviews.apache.org>
In-Reply-To: <20160105010600.26044.30527@reviews.apache.org>
Reply-To: "Gilbert Song" <songzihao1990@gmail.com>
X-ReviewRequest-Repository: mesos

--===============3358893543636397966==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112725
-----------------------------------------------------------

Ship it!


Ship It!

- Gilbert Song


On Jan. 4, 2016, 5:06 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4290
>     https://issues.apache.org/jira/browse/MESOS-4290
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 
> 
> Diff: https://reviews.apache.org/r/41909/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


--===============3358893543636397966==--