From reviews-return-18855-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 4 18:26:09 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 31B77180E9 for ; Mon, 4 Jan 2016 18:26:09 +0000 (UTC) Received: (qmail 41244 invoked by uid 500); 4 Jan 2016 18:26:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41217 invoked by uid 500); 4 Jan 2016 18:26:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41202 invoked by uid 99); 4 Jan 2016 18:26:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 18:26:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A23452979F0; Mon, 4 Jan 2016 18:26:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0717999044477712300==" MIME-Version: 1.0 Subject: Re: Review Request 41881: Provided constexpr Duration min and max values. From: "Joris Van Remoortere" To: "Joris Van Remoortere" , "Till Toenshoff" , "Jiang Yan Xu" Cc: "Benjamin Bannier" , "mesos" Date: Mon, 04 Jan 2016 18:26:07 -0000 Message-ID: <20160104182607.26043.83102@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41881/ X-Sender: "Joris Van Remoortere" References: <20160104112839.26043.52384@reviews.apache.org> In-Reply-To: <20160104112839.26043.52384@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============0717999044477712300== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112609 ----------------------------------------------------------- Looks good. How did you choose the particular functions to make constexpr. Why not the units for example? or others? - Joris Van Remoortere On Jan. 4, 2016, 11:28 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41881/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:28 a.m.) > > > Review request for mesos, Joris Van Remoortere, Till Toenshoff, and Jiang Yan Xu. > > > Bugs: MESOS-4277 > https://issues.apache.org/jira/browse/MESOS-4277 > > > Repository: mesos > > > Description > ------- > > For that we need to provide a constexpr constructor for Nanoseconds at > least; make all constructors of Duration types constexpr if possible. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 > > Diff: https://reviews.apache.org/r/41881/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Bannier > > --===============0717999044477712300==--