From reviews-return-18845-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 4 16:31:24 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9CF811888A for ; Mon, 4 Jan 2016 16:31:24 +0000 (UTC) Received: (qmail 86362 invoked by uid 500); 4 Jan 2016 16:31:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86339 invoked by uid 500); 4 Jan 2016 16:31:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86322 invoked by uid 99); 4 Jan 2016 16:31:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 16:31:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1FC64297891; Mon, 4 Jan 2016 16:31:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2118068874069222045==" MIME-Version: 1.0 Subject: Re: Review Request 40975: Document that libprocess ignores SIGPIPE From: "James Peach" To: "Ben Mahler" Cc: "James Peach" , "mesos" Date: Mon, 04 Jan 2016 16:31:23 -0000 Message-ID: <20160104163123.26044.38130@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "James Peach" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40975/ X-Sender: "James Peach" References: <20151229193238.4181.11456@reviews.apache.org> In-Reply-To: <20151229193238.4181.11456@reviews.apache.org> Reply-To: "James Peach" X-ReviewRequest-Repository: mesos --===============2118068874069222045== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 29, 2015, 7:32 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/README.md, lines 536-544 > > > > > > Hm.. since this document is about programming, do we need to say 'programming notes'? Or is 'notes' enough? > > > > It would be nice to also explain why we do this. Updated. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review112206 ----------------------------------------------------------- On Jan. 4, 2016, 4:31 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40975/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 4:31 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Document that libprocess ignores SIGPIPE. > > > Diffs > ----- > > 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 > > Diff: https://reviews.apache.org/r/40975/diff/ > > > Testing > ------- > > None. > > > Thanks, > > James Peach > > --===============2118068874069222045==--