From reviews-return-18799-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 4 10:35:34 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D10B186BF for ; Mon, 4 Jan 2016 10:35:34 +0000 (UTC) Received: (qmail 69134 invoked by uid 500); 4 Jan 2016 10:35:34 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 69107 invoked by uid 500); 4 Jan 2016 10:35:34 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 69089 invoked by uid 99); 4 Jan 2016 10:35:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 10:35:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9574129764C; Mon, 4 Jan 2016 10:35:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0630144758503125876==" MIME-Version: 1.0 Subject: Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1). From: "Michael Park" To: "Joris Van Remoortere" , "Benjamin Bannier" , "Michael Park" Cc: "Alexander Rukletsov" , "mesos" Date: Mon, 04 Jan 2016 10:35:32 -0000 Message-ID: <20160104103532.26044.78336@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Michael Park" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41511/ X-Sender: "Michael Park" References: <20151218134425.1672.62026@reviews.apache.org> In-Reply-To: <20151218134425.1672.62026@reviews.apache.org> Reply-To: "Michael Park" X-ReviewRequest-Repository: mesos --===============0630144758503125876== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 18, 2015, 1:44 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp, line 26 > > > > > > Looks like a forward decl is good enough here. > > Alexander Rukletsov wrote: > I'm not sure we can forward declare it since it's a template. As AlexR pointed out, the `operator<<` being defined is indeed a template and we therefore do need the full definition of `RepeatedPtrField`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/#review111181 ----------------------------------------------------------- On Dec. 22, 2015, 5:55 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41511/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 5:55 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > ------- > > Where possible move operator<< definitions and functions using streams > to ".cpp" files and include in ".hpp"s. Also remove unused I/O > includes, add necessary includes, clean up `std::` prefixes and blank > lines. > > > Diffs > ----- > > include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d > include/mesos/type_utils.hpp b370b5180e71ed246fa09bf0fe119dfa946d0b08 > include/mesos/v1/mesos.hpp 80e76040de77e65b20f10b0465124ab86c1feab6 > include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa > include/mesos/v1/values.hpp a160bd4d49d53fd2f794f36fea69ea99a455af09 > include/mesos/values.hpp 58af972186d7156660eac742b41501ce420cefe9 > src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 > src/common/type_utils.cpp c6c9ba7d1bfc6e6202b9e3ff94a74711e3602d6f > src/v1/mesos.cpp 13a58baf086ef3aaf46abcf7f58b71b7e2639728 > src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 > > Diff: https://reviews.apache.org/r/41511/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > > --===============0630144758503125876==--