From reviews-return-18795-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 4 10:21:42 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2C38185C9 for ; Mon, 4 Jan 2016 10:21:42 +0000 (UTC) Received: (qmail 33314 invoked by uid 500); 4 Jan 2016 10:21:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33286 invoked by uid 500); 4 Jan 2016 10:21:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33268 invoked by uid 99); 4 Jan 2016 10:21:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 10:21:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3F67029764C; Mon, 4 Jan 2016 10:21:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1842444003510990029==" MIME-Version: 1.0 Subject: Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1. From: "Michael Park" To: "Joris Van Remoortere" , "Benjamin Bannier" , "Michael Park" Cc: "Alexander Rukletsov" , "mesos" Date: Mon, 04 Jan 2016 10:21:41 -0000 Message-ID: <20160104102141.26043.48250@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Michael Park" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41512/ X-Sender: "Michael Park" References: <20151222175659.663.30942@reviews.apache.org> In-Reply-To: <20151222175659.663.30942@reviews.apache.org> Reply-To: "Michael Park" X-ReviewRequest-Repository: mesos --===============1842444003510990029== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/#review112535 ----------------------------------------------------------- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41512/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 5:56 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > ------- > > Where possible move `operator<<` definitions and functions using streams > to ".cpp" files and include in ".hpp"s. Also remove unused I/O > includes, add necessary includes, clean up `std::` prefixes. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d > include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 > src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa > src/common/http.cpp 2ecb78c582325c3e5141a9946516d6c9e8d7106f > > Diff: https://reviews.apache.org/r/41512/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > > --===============1842444003510990029==--