| Yongqiao Wang |
Re: Review Request 41672: Test case(s) for weights + allocation behavior |
Tue, 12 Jan, 09:35 |
| Anand Mazumdar |
Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library. |
Tue, 12 Jan, 09:51 |
| Alexander Rojas |
Re: Review Request 42164: Allowed (un)reserve operations without a principal. |
Tue, 12 Jan, 09:53 |
| Joerg Schad |
Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle. |
Tue, 12 Jan, 09:56 |
| Mesos ReviewBot |
Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions. |
Tue, 12 Jan, 10:38 |
| Mesos ReviewBot |
Re: Review Request 41879: Removed constructor which uses restricted width. |
Tue, 12 Jan, 11:29 |
| Mesos ReviewBot |
Re: Review Request 41790: Add tests for /weights endpoint. |
Tue, 12 Jan, 12:36 |
| Klaus Ma |
Review Request 42191: Added parameters to apply patches quiet. |
Tue, 12 Jan, 13:00 |
| Bernd Mathiske |
Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch. |
Tue, 12 Jan, 13:16 |
| Alexander Rojas |
Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch. |
Tue, 12 Jan, 13:28 |
| Mesos ReviewBot |
Re: Review Request 42040: Added Quota Operator Documentation. |
Tue, 12 Jan, 13:42 |
| Klaus Ma |
Re: Review Request 42191: Added parameters to apply patches quiet. |
Tue, 12 Jan, 13:54 |
| Mesos ReviewBot |
Re: Review Request 42186: Added tests for recovery for HTTP based executors. |
Tue, 12 Jan, 14:10 |
| Joerg Schad |
Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON into a function. |
Tue, 12 Jan, 14:22 |
| Joerg Schad |
Re: Review Request 41950: Cleaned up hierarchical allocator tests. |
Tue, 12 Jan, 14:26 |
| Mesos ReviewBot |
Re: Review Request 41672: Test case(s) for weights + allocation behavior |
Tue, 12 Jan, 14:30 |
| Benjamin Bannier |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 14:43 |
| Klaus Ma |
Review Request 42193: WIP: Added test for evicting executors. |
Tue, 12 Jan, 14:46 |
| Jan Schlicht |
Re: Review Request 41876: Used std::list as opposed to List from stout. |
Tue, 12 Jan, 14:52 |
| Guangya Liu |
Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (2/2). |
Tue, 12 Jan, 14:54 |
| Bernd Mathiske |
Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch. |
Tue, 12 Jan, 14:55 |
| Guangya Liu |
Re: Review Request 42113: WIP: Handle unreserve logic for dynamic reservation (1/2). |
Tue, 12 Jan, 14:55 |
| Yongqiao Wang |
Re: Review Request 41672: Test case(s) for weights + allocation behaviour. |
Tue, 12 Jan, 14:56 |
| Mesos ReviewBot |
Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle. |
Tue, 12 Jan, 14:56 |
| Jan Schlicht |
Re: Review Request 41875: Removed List type which is not needed anymore with C++11. |
Tue, 12 Jan, 14:57 |
| Joerg Schad |
Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle. |
Tue, 12 Jan, 15:01 |
| Mesos ReviewBot |
Re: Review Request 42191: Added parameters to apply patches quiet. |
Tue, 12 Jan, 16:02 |
| Mesos ReviewBot |
Re: Review Request 41950: Cleaned up hierarchical allocator tests. |
Tue, 12 Jan, 16:30 |
| Greg Mann |
Re: Review Request 42164: Allowed (un)reserve operations without a principal. |
Tue, 12 Jan, 16:43 |
| Greg Mann |
Re: Review Request 42164: Allowed (un)reserve operations without a principal. |
Tue, 12 Jan, 16:44 |
| Anand Mazumdar |
Re: Review Request 41275: Introduced a field for specifying grace period in shutdown event protobuf. |
Tue, 12 Jan, 17:29 |
| Anand Mazumdar |
Re: Review Request 41277: Added environment variables to be used by HTTP executors. |
Tue, 12 Jan, 17:29 |
| Anand Mazumdar |
Re: Review Request 41275: Introduced a field for specifying grace period in shutdown event. |
Tue, 12 Jan, 17:33 |
| Mesos ReviewBot |
Re: Review Request 42193: WIP: Added test for evicting executors. |
Tue, 12 Jan, 17:35 |
| Anand Mazumdar |
Re: Review Request 41285: Initialized `pid` to None() instead of `UPID()` in Slave. |
Tue, 12 Jan, 17:37 |
| Anand Mazumdar |
Re: Review Request 42182: Fixed check thereby allowing HTTP executors to reconnect. |
Tue, 12 Jan, 17:46 |
| Anand Mazumdar |
Re: Review Request 42186: Added tests for recovery for HTTP based executors. |
Tue, 12 Jan, 17:53 |
| Greg Mann |
Re: Review Request 42164: Allowed (un)reserve operations without a principal. |
Tue, 12 Jan, 18:00 |
| Joseph Wu |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 18:01 |
| Neil Conway |
Re: Review Request 42172: Add documentation for logging and ContainerLogger. |
Tue, 12 Jan, 18:03 |
| Greg Mann |
Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation. |
Tue, 12 Jan, 18:03 |
| Joseph Wu |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 18:04 |
| Kevin Klues |
Re: Review Request 42053: Add flags to set size of completed task/framework history. |
Tue, 12 Jan, 18:36 |
| Kevin Klues |
Re: Review Request 42053: Add flags to set size of completed task/framework history. |
Tue, 12 Jan, 18:37 |
| Kevin Klues |
Re: Review Request 42053: Add flags to set size of completed task/framework history. |
Tue, 12 Jan, 18:38 |
| Mesos ReviewBot |
Re: Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (2/2). |
Tue, 12 Jan, 18:38 |
| Greg Mann |
Re: Review Request 42164: Allowed (un)reserve operations without a principal. |
Tue, 12 Jan, 18:53 |
| Joseph Wu |
Re: Review Request 42172: Add documentation for logging and ContainerLogger. |
Tue, 12 Jan, 19:24 |
| Joseph Wu |
Re: Review Request 42172: Add documentation for logging and ContainerLogger. |
Tue, 12 Jan, 19:24 |
| Neil Conway |
Re: Review Request 42172: Add documentation for logging and ContainerLogger. |
Tue, 12 Jan, 19:26 |
| Mesos ReviewBot |
Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch. |
Tue, 12 Jan, 19:40 |
| Benjamin Bannier |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 19:41 |
| Joseph Wu |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 19:58 |
| Neil Conway |
Review Request 42208: Fixed flakiness in RegistryTokenTest.ExpiredToken. |
Tue, 12 Jan, 20:46 |
| Neil Conway |
Re: Review Request 42208: Fixed flakiness in RegistryTokenTest.ExpiredToken. |
Tue, 12 Jan, 20:46 |
| Neil Conway |
Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses. |
Tue, 12 Jan, 20:47 |
| Mesos ReviewBot |
Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle. |
Tue, 12 Jan, 21:19 |
| Alexander Rukletsov |
Re: Review Request 41936: Required role in set quota request explicitly. |
Tue, 12 Jan, 21:32 |
| Alexander Rukletsov |
Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON into a function. |
Tue, 12 Jan, 21:32 |
| Alexander Rukletsov |
Re: Review Request 41947: Changed signature of `QuotaInfo` validation. |
Tue, 12 Jan, 21:32 |
| Alexander Rukletsov |
Re: Review Request 41948: Ensured `QuotaInfo` is valid in registrar tests. |
Tue, 12 Jan, 21:33 |
| Alexander Rukletsov |
Re: Review Request 41938: Cleaned up quota tests. |
Tue, 12 Jan, 21:33 |
| Alexander Rukletsov |
Re: Review Request 41939: Simplified quota tests. |
Tue, 12 Jan, 21:33 |
| Alexander Rukletsov |
Re: Review Request 41949: Replaced `QuotaInfo` with `Quota` in allocator. |
Tue, 12 Jan, 21:33 |
| Alexander Rukletsov |
Re: Review Request 41648: Used initializer list c-tor for brevity. |
Tue, 12 Jan, 21:33 |
| Alexander Rukletsov |
Re: Review Request 41950: Cleaned up hierarchical allocator tests. |
Tue, 12 Jan, 21:34 |
| Vinod Kone |
Review Request 42209: Updated getting started page to install Java on OSX. |
Tue, 12 Jan, 21:38 |
| Mesos ReviewBot |
Re: Review Request 42186: Added tests for recovery for HTTP based executors. |
Tue, 12 Jan, 21:42 |
| Artem Harutyunyan |
Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox. |
Tue, 12 Jan, 21:48 |
| Artem Harutyunyan |
Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox. |
Tue, 12 Jan, 21:50 |
| Neil Conway |
Re: Review Request 42121: Replaced `Clock::settle()` with `os::sleep` in test case. |
Tue, 12 Jan, 22:04 |
| Kevin Klues |
Re: Review Request 42209: Updated getting started page to install Java on OSX. |
Tue, 12 Jan, 22:04 |
| Kevin Klues |
Re: Review Request 42053: Add flags to set size of completed task/framework history. |
Tue, 12 Jan, 22:05 |
| Avinash sridharan |
Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable. |
Tue, 12 Jan, 22:06 |
| Kevin Klues |
Re: Review Request 42053: Added flags to set size of completed task/framework history. |
Tue, 12 Jan, 22:06 |
| Kevin Klues |
Review Request 42212: Added unit test for framework/task history flags. |
Tue, 12 Jan, 22:08 |
| Kevin Klues |
Re: Review Request 42212: Added unit test for framework/task history flags. |
Tue, 12 Jan, 22:12 |
| James Peach |
Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search. |
Tue, 12 Jan, 22:14 |
| James Peach |
Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search. |
Tue, 12 Jan, 22:14 |
| James Peach |
Re: Review Request 39782: Add a comment for os::libraries::setPaths. |
Tue, 12 Jan, 22:14 |
| Kevin Klues |
Re: Review Request 42053: Added flags to set size of completed task/framework history. |
Tue, 12 Jan, 22:15 |
| Joseph Wu |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 22:20 |
| Joseph Wu |
Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers. |
Tue, 12 Jan, 22:21 |
| Anand Mazumdar |
Review Request 42216: Fixed gmock warnings in hook tests. |
Tue, 12 Jan, 22:27 |
| Joseph Wu |
Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess. |
Tue, 12 Jan, 22:28 |
| Joseph Wu |
Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover. |
Tue, 12 Jan, 22:31 |
| Joseph Wu |
Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery. |
Tue, 12 Jan, 22:31 |
| Greg Mann |
Review Request 42215: Added expectations for call to mocked executor shutdown. |
Tue, 12 Jan, 22:32 |
| Adam B |
Re: Review Request 42053: Added flags to set size of completed task/framework history. |
Tue, 12 Jan, 22:33 |
| Vinod Kone |
Re: Review Request 42209: Updated getting started page to install Java on OSX. |
Tue, 12 Jan, 22:37 |
| Anand Mazumdar |
Review Request 42217: Modified commit msg hook to include newline character. |
Tue, 12 Jan, 22:41 |
| Joseph Wu |
Re: Review Request 42209: Updated getting started page to install Java on OSX. |
Tue, 12 Jan, 22:42 |
| Vinod Kone |
Re: Review Request 41277: Added environment variables to be used by HTTP executors. |
Tue, 12 Jan, 22:45 |
| Vinod Kone |
Re: Review Request 41280: Fixed header include order. |
Tue, 12 Jan, 22:46 |
| Vinod Kone |
Re: Review Request 41281: Added output operator to output call/event types in the Executor V1 API. |
Tue, 12 Jan, 22:46 |
| James Peach |
Re: Review Request 40553: Enable mesos tests installation |
Tue, 12 Jan, 22:50 |
| Mesos ReviewBot |
Re: Review Request 42172: Add documentation for logging and ContainerLogger. |
Tue, 12 Jan, 22:55 |
| Adam B |
Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses. |
Tue, 12 Jan, 22:56 |
| Adam B |
Re: Review Request 42217: Modified commit msg hook to include newline character. |
Tue, 12 Jan, 22:58 |
| Joseph Wu |
Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch. |
Tue, 12 Jan, 23:02 |