mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.
Date Sun, 31 Jan 2016 21:55:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43023/#review117157
-----------------------------------------------------------


Fix it, then Ship it!




+ resolution with neil's comments.


3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 152)
<https://reviews.apache.org/r/43023/#comment178241>

    const?


- Joris Van Remoortere


On Jan. 31, 2016, 4:51 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43023/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2016, 4:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4566
>     https://issues.apache.org/jira/browse/MESOS-4566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this patch + https://reviews.apache.org/r/43024/, the number of calls to `operator
new` and `operator delete` were reduced by roughly 1/3.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp addec8ec6504e2a8f5b838fce3ebd4db224ab022

> 
> Diff: https://reviews.apache.org/r/43023/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message