mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 43035: Added a test for the interaction between timers and destroyed Groups.
Date Sun, 31 Jan 2016 19:43:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
-------

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs
-----

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
-------

make check

I also verified that if you remove the `delete` of the `GroupProcess`, the test fails because
the `expired` callback is invoked (the `Clock::settle()` is necessary to ensure that this
happens).


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message