mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 42956: Added variadic template for process::await.
Date Sat, 30 Jan 2016 01:57:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/#review117078
-----------------------------------------------------------


Ship it!




Thanks for fixing this debt!


3rdparty/libprocess/include/process/collect.hpp (lines 249 - 250)
<https://reviews.apache.org/r/42956/#comment178126>

    Ditto from last review here, newline and .then on newline (since we treat it like a statement).


- Ben Mahler


On Jan. 30, 2016, 1:43 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42956/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 1:43 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4551
>     https://issues.apache.org/jira/browse/MESOS-4551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, templates only existed to allow await to take either a
> std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
> Futures as arguments.
> 
> This commit removes the 2 and 3 argument templates and replaces them
> with a variadic template that accepts an arbitrary number of Futures as
> arguments.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9

> 
> Diff: https://reviews.apache.org/r/42956/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message