mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 42956: Added variadic template for process::await.
Date Sat, 30 Jan 2016 01:43:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/
-----------------------------------------------------------

(Updated Jan. 30, 2016, 1:43 a.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
-------

Checks were hanging due to the wcall to futures.get()... in the bind call for collect(). 
We rearranged things to avoid this. We changed await to be consistent with the new pattern.


Bugs: MESOS-4551
    https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
-------

Previously, templates only existed to allow await to take either a
std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
Futures as arguments.

This commit removes the 2 and 3 argument templates and replaces them
with a variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/collect.hpp cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9


Diff: https://reviews.apache.org/r/42956/diff/


Testing
-------


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message